[libvirt PATCH v2 06/12] nodedev: driver: Introduce internal mdevctl commands enum

Erik Skultety eskultet at redhat.com
Wed Apr 14 10:41:02 UTC 2021


On Tue, Apr 13, 2021 at 03:39:42PM -0500, Jonathon Jongsma wrote:
> From: Erik Skultety <eskultet at redhat.com>
> 
> This is not a 1:1 mapping to mdevctl because mdevctl doesn't support a
> 'create' command. It uses 'start' for both starting a defined device as
> well as creating a transient one. To make our code more readable in
> that regard and not second-guess what does a specific "start" instance
> mean, use "create" internally instead only to translate it to "start"
> just before executing mdevctl.

Reading ^this for the second time, I think we need to rephrase the second
sentence, as it's difficult to read and that's something since I wrote it :D.

Erik




More information about the libvir-list mailing list