[libvirt PATCH v2 00/12] Some additional cleanups to mdev support
Erik Skultety
eskultet at redhat.com
Wed Apr 14 10:49:38 UTC 2021
On Tue, Apr 13, 2021 at 03:39:36PM -0500, Jonathon Jongsma wrote:
> Erik recommended several changes to the mdev series that was just merged and
> suggested to address them in a follow-up patch series. They're mostly related
> to simplifying the testing, and shouldn't actually change any behavior (aside
> from switching to using the long commandline options when executing mdevctl).
>
> Changes in v2:
> - rebase to lastest git master
>
> Erik Skultety (4):
> nodedev: driver: Swap virMdevctlStart and virMdevctlCreate
> nodedev: driver: Introduce internal mdevctl commands enum
> nodedev: driver: Create a generic mdevctl command translator
> tests: nodedev: Make the mdevctl test function and helper generic
>
> Jonathon Jongsma (8):
> nodedev: don't log error in nodeDeviceFindAddressByName()
> nodedev: avoid use of VIR_ERR_NO_* errors internally
> tests: nodedev: switch all test macros to accept a filename
> nodedev: Switch to using long options for mdevctl
> nodedev: Remove GetMdevctl*Command() wrappers
> tests: nodedev: simplify test macros
> tests: nodedev: remove unused variable
> tests: nodedev: remove unnecessary cleanup label
The changes look good to me and I'm tempted to put my R-b even on the rest of
the patches, but since I have a fair share on the patches that I didn't comment
on, it suddenly feels like circumventing the rules (I know I suggested you
go ahead and submit the patches). Let's give it a few days and hopefully
someone else gives you a second opinion especially on the patches that bear my
signoff.
Regards,
Erik
More information about the libvir-list
mailing list