[libvirt PATCH 1/2] Fix spelling

Ján Tomko jtomko at redhat.com
Wed Apr 14 17:46:05 UTC 2021


On a Wednesday in 2021, Tim Wiederhake wrote:
>Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
>---
> NEWS.rst                           | 12 ++++++------
> docs/formatdomain.rst              |  6 +++---
> docs/glib-adoption.rst             |  2 +-
> docs/kbase/launch_security_sev.rst |  2 +-
> docs/manpages/virtproxyd.rst       |  2 +-
> docs/pci-addresses.rst             |  2 +-
> src/hyperv/hyperv_wmi.c            |  2 +-
> src/libvirt-domain.c               |  2 +-
> src/libxl/libxl_logger.c           |  2 +-
> src/qemu/qemu_capabilities.c       |  2 +-
> src/qemu/qemu_command.c            |  2 +-
> src/qemu/qemu_domain.c             |  4 ++--
> src/qemu/qemu_domain.h             |  4 ++--
> src/qemu/qemu_interface.c          |  2 +-
> src/qemu/qemu_snapshot.c           |  4 ++--
> src/util/virerror.c                |  3 ++-
> src/util/virhash.c                 |  2 +-
> src/util/virnetdev.c               |  2 +-
> src/util/virpci.c                  |  2 +-
> src/util/virpci.h                  |  2 +-
> tests/meson.build                  |  2 +-
> tools/meson.build                  |  2 +-
> 22 files changed, 33 insertions(+), 32 deletions(-)
>
>diff --git a/NEWS.rst b/NEWS.rst
>index 0a34798483..488e4a63a1 100644
>--- a/NEWS.rst
>+++ b/NEWS.rst
>@@ -1900,7 +1900,7 @@ v5.3.0 (2019-05-04)
>
>   * virsh: various completers fixes
>
>-    There were some possible crashers, memory leaks, etc. which are now fixed.
>+    There were some possible crashes, memory leaks, etc. which are now fixed.
>

I believe 'crasher' here was intentional, as in: a bug that causes a
crash.

>   * qemu: Make hugepages work with memfd backend
>
>diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst
>index f969ac80a1..c2cec80eea 100644
>--- a/docs/glib-adoption.rst
>+++ b/docs/glib-adoption.rst
>@@ -32,7 +32,7 @@ Array operations
>
>    https://developer.gnome.org/glib/stable/glib-Arrays.html
>
>-   Instead of using plain C arrays, it is preferrable to use one of
>+   Instead of using plain C arrays, it is preferable to use one of

Collins Dictionary lists 'preferrable' as a less used alternative:
https://www.collinsdictionary.com/dictionary/english/preferrable
so I would not call the original wrong either.

>    the GLib types, ``GArray``, ``GPtrArray`` or ``GByteArray``.
>    These all use a struct to track the array memory and size
>    together and efficiently resize.
>diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c
>index 1da3357c6d..a0e4dd40c3 100644
>--- a/src/libxl/libxl_logger.c
>+++ b/src/libxl/libxl_logger.c
>@@ -117,7 +117,7 @@ libvirt_progress(xentoollog_logger *logger_in G_GNUC_UNUSED,
>                  unsigned long done G_GNUC_UNUSED,
>                  unsigned long total G_GNUC_UNUSED)
> {
>-    /* This function purposedly does nothing: it's no logging info */
>+    /* This function purposely does nothing: it's no logging info */

purposedly also looks like a valid word:
https://www.merriam-webster.com/dictionary/purposedly

> }
>
> static void

To the rest:
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210414/a04a1d58/attachment-0001.sig>


More information about the libvir-list mailing list