[libvirt PATCH 0/2] Always validate XML for (hypervisor-)cpu-compare

Tim Wiederhake twiederh at redhat.com
Thu Apr 15 08:40:52 UTC 2021


XML schema validation for `virsh (hypervisor-)cpu-compare` has to be
enabled explicitly by passing the `--validate` flag. Having invalid
XML domain / cpu specification that appear to work can lead to hard
to find problems down the line, when e.g. migration of VMs does not
work as expected.

This series fixes a bug in the validation code and logs the schema
validation error to libvirtd's log file. User facing behaviour stays
unchanged.

See this conversation for more background:
https://listman.redhat.com/archives/libvir-list/2021-March/msg01214.html

Tim Wiederhake (2):
  virxml: Fix schema validation of individual nodes
  virCPUDefParseXML: Log schema validation errors

 src/conf/cpu_conf.c | 16 +++++++---------
 src/util/virxml.c   | 13 ++++++-------
 src/util/virxml.h   |  1 -
 3 files changed, 13 insertions(+), 17 deletions(-)

-- 
2.26.2





More information about the libvir-list mailing list