[libvirt PATCH 03/17] virdnsmasq: drop unused dnsmasqCapsRefresh function

Pavel Hrdina phrdina at redhat.com
Fri Apr 16 19:12:32 UTC 2021


Instead of removing binaryPath let's drop the function completely as
it is not used anywhere.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/libvirt_private.syms |  1 -
 src/util/virdnsmasq.c    | 17 -----------------
 src/util/virdnsmasq.h    |  1 -
 3 files changed, 19 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 982e3bb68d..912c328821 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -2090,7 +2090,6 @@ dnsmasqCapsGetBinaryPath;
 dnsmasqCapsGetVersion;
 dnsmasqCapsNewFromBinary;
 dnsmasqCapsNewFromBuffer;
-dnsmasqCapsRefresh;
 dnsmasqContextFree;
 dnsmasqContextNew;
 dnsmasqDelete;
diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c
index 57f7ef67f1..89f33c22a8 100644
--- a/src/util/virdnsmasq.c
+++ b/src/util/virdnsmasq.c
@@ -773,23 +773,6 @@ dnsmasqCapsNewFromBinary(const char *binaryPath)
     return caps;
 }
 
-/** dnsmasqCapsRefresh:
- *
- *   Refresh an existing caps object if the binary has changed. If
- *   there isn't yet a caps object (if it's NULL), create a new one.
- *
- *   Returns 0 on success, -1 on failure
- */
-int
-dnsmasqCapsRefresh(dnsmasqCaps **caps, const char *binaryPath)
-{
-    if (!*caps) {
-        *caps = dnsmasqCapsNewFromBinary(binaryPath);
-        return *caps ? 0 : -1;
-    }
-    return dnsmasqCapsRefreshInternal(*caps, false);
-}
-
 const char *
 dnsmasqCapsGetBinaryPath(dnsmasqCaps *caps)
 {
diff --git a/src/util/virdnsmasq.h b/src/util/virdnsmasq.h
index 09e6164dc0..8b9474f774 100644
--- a/src/util/virdnsmasq.h
+++ b/src/util/virdnsmasq.h
@@ -102,7 +102,6 @@ int              dnsmasqReload(pid_t pid);
 dnsmasqCaps *dnsmasqCapsNewFromBuffer(const char *buf,
                                         const char *binaryPath);
 dnsmasqCaps *dnsmasqCapsNewFromBinary(const char *binaryPath);
-int dnsmasqCapsRefresh(dnsmasqCaps **caps, const char *binaryPath);
 bool dnsmasqCapsGet(dnsmasqCaps *caps, dnsmasqCapsFlags flag);
 const char *dnsmasqCapsGetBinaryPath(dnsmasqCaps *caps);
 unsigned long dnsmasqCapsGetVersion(dnsmasqCaps *caps);
-- 
2.30.2




More information about the libvir-list mailing list