[libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

Michal Privoznik mprivozn at redhat.com
Mon Apr 19 09:45:07 UTC 2021


On 4/15/21 2:52 PM, Andrea Bolognani wrote:
> The former is ridiculously tiny and doesn't have any use on
> its own, so it hardly warrants the overhead of an additional
> package; 

The idea was, that if you'd install virt-admin only, you would have bash 
completion too, hence a separate package.

> the latter is also very small and, just like virsh,
> is something that you likely want to have available on any
> virtualization host to help with management and debugging
> tasks.

Exactly! Host, not client. Not every virt client is virt host too. Also, 
what's stopping management from installing libvirt-admin among with 
other RPMs? It's tiny, as you say. But I think I've expressed my concern 
enough.

> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> Changes from [v1]:
> 
>    * add Obsoletes/Provides for a smooth transition.
> 
> [v1] https://listman.redhat.com/archives/libvir-list/2021-April/msg00604.html
> 
>   libvirt.spec.in | 34 ++++++++++------------------------
>   1 file changed, 10 insertions(+), 24 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list