Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices

[Gavi Teitz]

On Monday, April 19, 2021 18:10
Jonathon Jongsma <jjongsma at redhat.com> wrote:

>On Mon, 19 Apr 2021 14:16:59 +0200
>Michal Privoznik <mprivozn at redhat.com> wrote:
>
>> On 4/18/21 10:08 AM, Gavi Teitz wrote:
>> > Hi,
>> > 
>> > The page-per-vq flag is important for vdpa with vhost-user 
>> > performance [1].
>> > 
>> > Currently there is no way in libvirt to set it in the xml 
>> > page-per-vq except with qemu args, like so:
>> 
>> Yeah, we view extra cmd line arguments as unsupported.
>> 
>> > 
>> > Are there any issues that would prevent this feature from being 
>> > accepted?
>> 
>> Not at all, please do send a patch and I can review it.
>> 
>> Michal
>> 
>
>There is a related bug currently assigned to me that I was intending to look at soon: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D1925363&data=04%7C01%7Cgavi%40nvidia.com%7C62de22da136a4956041308d903454846%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637544418369075797%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=61ku0MktohQ9BArBWug0HKeO7g1mKl2r2h824jLo1MM%3D&reserved=0
>
>Jonathon
>

Yep, that is the issue we opened, we are promoting a fix for it, I should have the patch ready in the next few days.

Thanks,
Gavi