[libvirt PATCH v2 06/21] virfirewall: use virFindFileInPath instead of virFileIsExecutable

Pavel Hrdina phrdina at redhat.com
Mon Apr 19 17:14:09 UTC 2021


Following patches will make this change necessary as we will stop
detecting the full path during compile time.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/util/virfirewall.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c
index 78aa7e580e..e79fe52ac8 100644
--- a/src/util/virfirewall.c
+++ b/src/util/virfirewall.c
@@ -104,7 +104,9 @@ virFirewallValidateBackend(virFirewallBackend backend)
     size_t i;
 
     for (i = 0; i < G_N_ELEMENTS(commands); i++) {
-        if (!virFileIsExecutable(commands[i])) {
+        g_autofree char *path = virFindFileInPath(commands[i]);
+
+        if (!path) {
             virReportSystemError(errno,
                                  _("%s not available, firewall backend will not function"),
                                  commands[i]);
-- 
2.30.2




More information about the libvir-list mailing list