[libvirt PATCH v3 2/4] spec: Move some files from -client to -daemon

Michal Privoznik mprivozn at redhat.com
Tue Apr 20 14:10:45 UTC 2021


On 4/20/21 2:30 PM, Andrea Bolognani wrote:
> The -client package's purpose is enabling remote machines to
> connect to a virtualization host, but the virt-host-validate
> and libvirt-guests tools are designed to be run directly on
> the virtualization host and as such are a better fit for the
> -daemon package.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>   libvirt.spec.in | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index db88b1bf3d..5bdf12898f 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -463,6 +463,8 @@ Requires: numad
>   Requires: dbus
>   # For uid creation during pre
>   Requires(pre): shadow-utils
> +# Needed by /usr/libexec/libvirt-guests.sh script.
> +Requires: gettext
>   
>   # Ensure smooth upgrades
>   Obsoletes: libvirt-admin < 7.3.0
> @@ -904,8 +906,6 @@ capabilities of VirtualBox
>   %package client
>   Summary: Client side utilities of the libvirt library
>   Requires: %{name}-libs = %{version}-%{release}
> -# Needed by /usr/libexec/libvirt-guests.sh script.
> -Requires: gettext
>   # Needed by virt-pki-validate script.
>   Requires: gnutls-utils
>   Requires: %{name}-bash-completion = %{version}-%{release}
> @@ -1533,6 +1533,7 @@ exit 0
>   %{_unitdir}/virtlockd.service
>   %{_unitdir}/virtlockd.socket
>   %{_unitdir}/virtlockd-admin.socket
> +%{_unitdir}/libvirt-guests.service
>   %config(noreplace) %{_sysconfdir}/sysconfig/libvirtd
>   %config(noreplace) %{_sysconfdir}/sysconfig/virtproxyd
>   %config(noreplace) %{_sysconfdir}/sysconfig/virtlogd

Doesn't this mean that the %systemd_preun %systemd_post and 
%systemd_postun machinery should be now done in -daemon instead of 
-client? I mean, if -daemon installs a service file I don't see why 
-client should refresh systemd's state.

Michal




More information about the libvir-list mailing list