[libvirt PATCH v4 7/7] spec: Drop -bash-completion package

Andrea Bolognani abologna at redhat.com
Tue Apr 20 17:13:22 UTC 2021


It's now empty, so no point in keeping it around.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 docs/kbase/rpm-deployment.rst |  6 ------
 libvirt.spec.in               | 14 ++++----------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst
index cc2a4eb288..7b3bbfefe8 100644
--- a/docs/kbase/rpm-deployment.rst
+++ b/docs/kbase/rpm-deployment.rst
@@ -27,12 +27,6 @@ RPM packages
   every other libvirt RPM package. Almost every deployment scenario would be
   better served by picking one of the other RPMs listed below.
 
-* libvirt-bash-completion
-
-  Argument auto-completion support for the Bash shell. This is shared code that
-  is pulled in by either the libvirt-admin or libvirt-clients RPMs, so there is
-  no need to explicitly ask for this package to be installed.
-
 * libvirt-client
 
   The virsh tool, used for interacting with any libvirt driver, both primary
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 76af267681..b7359b3763 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -430,9 +430,6 @@ Summary: Server side daemon and supporting files for libvirt library
 # The client side, i.e. shared libs are in a subpackage
 Requires: %{name}-libs = %{version}-%{release}
 
-# bash completion support for virt-admin
-Requires: %{name}-bash-completion = %{version}-%{release}
-
 # (client invokes 'nc' against the UNIX socket on the server)
 Requires: /usr/bin/nc
 
@@ -469,6 +466,7 @@ Requires: gettext
 # Ensure smooth upgrades
 Obsoletes: libvirt-admin < 7.3.0
 Provides: libvirt-admin
+Obsoletes: libvirt-bash-completion < 7.3.0
 
 %description daemon
 Server side daemon required to manage the virtualization capabilities
@@ -908,7 +906,9 @@ Summary: Client side utilities of the libvirt library
 Requires: %{name}-libs = %{version}-%{release}
 # Needed by virt-pki-validate script.
 Requires: gnutls-utils
-Requires: %{name}-bash-completion = %{version}-%{release}
+
+# Ensure smooth upgrades
+Obsoletes: libvirt-bash-completion < 7.3.0
 
 %description client
 The client binaries needed to access the virtualization
@@ -925,12 +925,6 @@ Requires: cyrus-sasl-gssapi
 %description libs
 Shared libraries for accessing the libvirt daemon.
 
-%package bash-completion
-Summary: Bash completion script
-
-%description bash-completion
-Bash completion script stub.
-
 %if %{with_wireshark}
 %package wireshark
 Summary: Wireshark dissector plugin for libvirt RPC transactions
-- 
2.26.3




More information about the libvir-list mailing list