[libvirt PATCH 06/10] virDomainChrSourceDefParseLog: Use virXMLProp*

Tim Wiederhake twiederh at redhat.com
Wed Apr 21 13:33:28 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/conf/domain_conf.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d10d697884..c97a062d1f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -11713,20 +11713,11 @@ static int
 virDomainChrSourceDefParseLog(virDomainChrSourceDef *def,
                               xmlNodePtr log)
 {
-    g_autofree char *append = NULL;
-
     def->logfile = virXMLPropString(log, "file");
 
-    if ((append = virXMLPropString(log, "append"))) {
-        int value;
-        if ((value = virTristateSwitchTypeFromString(append)) <= 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("Invalid append attribute value '%s'"),
-                           append);
-            return -1;
-        }
-        def->logappend = value;
-    }
+    if (virXMLPropTristateSwitch(log, "append", VIR_XML_PROP_NONE,
+                                 &def->logappend) < 0)
+        return -1;
 
     return 0;
 }
-- 
2.26.3




More information about the libvir-list mailing list