[libvirt PATCH] storage_backend_fs: use MKFS ony if WITH_STORAGE_FS is defined

Pavel Hrdina phrdina at redhat.com
Wed Apr 21 13:33:52 UTC 2021


The code in storage_backend_fs is used for storage_dir and storage_fs
drivers so some parts need to be guarded by checking for
WITH_STORAGE_FS.

Fixes: 16c69e7aaed4cabfd8e8c19cc326854d4c480437
Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

GitLab CI faild on MacOS and FreeBSD where storage_fs is disabled.

 src/storage/storage_backend_fs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index af645ea9de..e6a348521d 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -401,6 +401,7 @@ static int
 virStorageBackendExecuteMKFS(const char *device,
                              const char *format)
 {
+#if WITH_STORAGE_FS
     g_autoptr(virCommand) cmd = NULL;
     g_autofree char *mkfs = virFindFileInPath(MKFS);
 
@@ -431,6 +432,7 @@ virStorageBackendExecuteMKFS(const char *device,
     if (virCommandRun(cmd, NULL) < 0)
         return -1;
 
+#endif /* WITH_STORAGE_FS */
     return 0;
 }
 
-- 
2.30.2




More information about the libvir-list mailing list