[RFC PATCH 0/7] Fix issue when storage migration is requested but there are no disks to migrate

[Michal Privoznik]

On 4/13/21 5:38 PM, Peter Krempa wrote:
> In certain weird cases and due to very crusty code we'd instruct qemu to
> migrate storage using the old style storage migration when there wasn't
> anything to migrate. This was caused by a recent refactor.
> 
> Note that the series is RFC as I didn't really test it yet, but feel
> free to provide feedback.
> 
> Peter Krempa (7):
>    util: xml: Introduce virXMLFormatElementEmpty
>    qemuMigrationCookieNBDXMLFormat: Format empty <nbd/> element
>    qemuMigrationSrcNBDStorageCopy: Return error code on error
>    qemuMigrationSrcNBDStorageCopy: Don't pass migrate_flags
>    qemuMigrationSrcRun: Sanitize setting of cookieFlags and migrate_flags
>      on storage migration
>    qemuMigrationSrcRun: Don't attempt any storage migration if no disks
>      will be migrated
>    qemuMigrationSrcBeginPhase: Don't offer 'nbd' in cookie if there are
>      no disks to migrate
> 
>   src/libvirt_private.syms         |   1 +
>   src/qemu/qemu_migration.c        | 102 ++++++++++++++++++-------------
>   src/qemu/qemu_migration_cookie.c |   2 +-
>   src/util/virxml.c                |  42 ++++++++-----
>   src/util/virxml.h                |   7 +++
>   5 files changed, 95 insertions(+), 59 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal