[PATCH 05/10] qemuBackupJobCancelBlockjobs: Replace qemuMonitorJobCancel by qemuMonitorBlockJobCancel

Peter Krempa pkrempa at redhat.com
Wed Apr 21 14:04:35 UTC 2021


We want to unify on one block job cancellation API. Use
qemuMonitorBlockJobCancel which has more features.

In case of backup jobs we can cancel the jobs forcefully since the code
is on a cleanup path when the job fails.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_backup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index df9ca5b99f..4f1e3b7bad 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -676,7 +676,7 @@ qemuBackupJobCancelBlockjobs(virDomainObj *vm,
         if (qemuDomainObjEnterMonitorAsync(priv->driver, vm, asyncJob) < 0)
             return;

-        rc = qemuMonitorJobCancel(priv->mon, job->name, false);
+        rc = qemuMonitorBlockJobCancel(priv->mon, job->name, true);

         if (qemuDomainObjExitMonitor(priv->driver, vm) < 0)
             return;
-- 
2.30.2




More information about the libvir-list mailing list