[PATCH 1/4] lxc_controller: Initialize ctrl->handshakeFd properly
Martin Kletzander
mkletzan at redhat.com
Thu Apr 22 11:25:41 UTC 2021
On Tue, Apr 20, 2021 at 04:15:15PM +0200, Michal Privoznik wrote:
>The lxc_controller has a structure that's keeping its internal
>state, including so called handshakeFd which is the write end of
>a pipe that's used to signal to the LXC driver that the container
>is set up and ready to run. However, the struct member is not
>initialized to -1, so if anything fails before it is set then the
>virLXCControllerFree() function tries to close FD 0 (stdin).
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/lxc/lxc_controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
>diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
>index ab5fc8b88f..50b2987d9a 100644
>--- a/src/lxc/lxc_controller.c
>+++ b/src/lxc/lxc_controller.c
>@@ -193,8 +193,8 @@ static virLXCController *virLXCControllerNew(const char *name)
>
> ctrl->timerShutdown = -1;
> ctrl->firstClient = true;
>-
> ctrl->name = g_strdup(name);
>+ ctrl->handshakeFd = -1;
>
> if (!(driver = virLXCControllerDriverNew()))
> goto error;
>--
>2.26.3
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210422/ec5288e2/attachment-0001.sig>
More information about the libvir-list
mailing list