[libvirt PATCH 04/11] ci: util: Add _raw suffix to get_registry_images()

Andrea Bolognani abologna at redhat.com
Fri Apr 23 15:03:01 UTC 2021


This stresses the fact that the function returns the data
obtained from the GitLab API in its raw form; later on, we're
going to implement a more convenient wrapper that extracts
the information we're interested in and processes it so that
it can be used more conveniently.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 ci/helper  | 2 +-
 ci/util.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ci/helper b/ci/helper
index 2c3a9f8db4..eb037d3495 100755
--- a/ci/helper
+++ b/ci/helper
@@ -309,7 +309,7 @@ class Application:
     def _action_list_images(self):
         registry_uri = util.get_registry_uri(self._args.namespace,
                                              self._args.gitlab_uri)
-        images = util.get_registry_images(registry_uri)
+        images = util.get_registry_images_raw(registry_uri)
 
         # skip the "ci-" prefix each of our container images' name has
         name_prefix = "ci-"
diff --git a/ci/util.py b/ci/util.py
index 625428f339..b6a99ce9c0 100644
--- a/ci/util.py
+++ b/ci/util.py
@@ -24,7 +24,7 @@ def get_registry_uri(namespace: str,
     return uri
 
 
-def get_registry_images(uri: str) -> List[Dict]:
+def get_registry_images_raw(uri: str) -> List[Dict]:
     """
     List all container images that are currently available in the given GitLab
     project.
@@ -83,7 +83,7 @@ def get_registry_stale_images(registry_uri: str,
     :return: dictionary formatted as: {<gitlab_image_name>: <gitlab_image_id>}
     """
 
-    images = get_registry_images(registry_uri)
+    images = get_registry_images_raw(registry_uri)
 
     stale_images = {}
     for img in images:
-- 
2.26.3




More information about the libvir-list mailing list