[libvirt PATCH 10/11] ci: helper: Enable gitlabparser for container actions

Andrea Bolognani abologna at redhat.com
Fri Apr 23 15:03:07 UTC 2021


Unfortunately this doesn't work completely yet, because the
underlying Makefile has no notion of the --namespace and
--gitlab-uri arguments, but we need the subparser to be
enabled so that we can use the corresponding information in
_make_run_action() for validation purposes.

Once we've reimplemented the Makefile part in Python, then
the new arguments will start working as expected.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 ci/helper | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ci/helper b/ci/helper
index e39934d357..cd3069a89a 100755
--- a/ci/helper
+++ b/ci/helper
@@ -99,7 +99,7 @@ class Parser:
         buildparser = subparsers.add_parser(
             "build",
             help="run a build in a container",
-            parents=[containerparser, mesonparser],
+            parents=[gitlabparser, containerparser, mesonparser],
             formatter_class=argparse.ArgumentDefaultsHelpFormatter,
         )
         buildparser.set_defaults(func=Application._action_build)
@@ -108,7 +108,7 @@ class Parser:
         testparser = subparsers.add_parser(
             "test",
             help="run a build in a container (including tests)",
-            parents=[containerparser, mesonparser],
+            parents=[gitlabparser, containerparser, mesonparser],
             formatter_class=argparse.ArgumentDefaultsHelpFormatter,
         )
         testparser.set_defaults(func=Application._action_test)
@@ -117,7 +117,7 @@ class Parser:
         shellparser = subparsers.add_parser(
             "shell",
             help="start a shell in a container",
-            parents=[containerparser],
+            parents=[gitlabparser, containerparser],
             formatter_class=argparse.ArgumentDefaultsHelpFormatter,
         )
         shellparser.set_defaults(func=Application._action_shell)
-- 
2.26.3




More information about the libvir-list mailing list