[PATCH] NEWS: Mention notable changes

Peter Krempa pkrempa at redhat.com
Wed Apr 28 06:44:32 UTC 2021


On Tue, Apr 27, 2021 at 09:12:01 -0500, jjongsma at redhat.com wrote:
> On Tue, 2021-04-27 at 15:37 +0200, Peter Krempa wrote:
> > Add entries for deprecation_behavior, improving of errors from
> > virsh's
> > snapshot helpers and other bugfixes.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  NEWS.rst | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> > 
> > diff --git a/NEWS.rst b/NEWS.rst
> > index 5f8b0ae02d..4a5e2c9fd4 100644
> > --- a/NEWS.rst
> > +++ b/NEWS.rst
> > @@ -18,10 +18,58 @@ v7.3.0 (unreleased)
> >      The xen driver now supports domains with more than 4TB of memory
> > with
> >      xen >= 4.13.
> > 
> > +  * qemu: Allow use of qemu's ``-compat`` option
> > +
> > +    Curious developers or testers now can enable certain ``-compat`` 
> > modes which
> > +    allow to notice use of deprecated commands and options as qemu
> > will use the
> > +    selected method to notify the user. The new behaviour can be
> > requested using
> > +    either the ``deprecation_behavior`` option in ``qemu.conf`` for
> > all VMs or
> > +    using ``<qemu:deprecation behavior='...'/>`` in the VM XML.
> > +
> >  * **Improvements**
> > 
> > +  * virsh: Improve errors with ``virsh snapshot-create-as``
> > +
> > +    The XML constructed by virsh was forced through RNG schema
> > validation which
> 
> I initially read that as "Random Number Generator schema validation"
> and was a bit confused. Just FYI.

Good point. I've changed it to "XML schema validation" as mentioning the
specific schema language isn't adding to the clarity.

> > +    yielded unintelligible error messages in cases such as when the
> > path to
> > +    the new image was not starting with a slash.
> 
> Perhaps change "was not starting with" to "did not start with"
> 
> >  XMLs are no longer validated
> 
> Personal nit: XMLs technically expands to Extensible Markup Languages,
> which sounds a bit off to my ears. I prefer something like "XML files"

I went with 'XML document' since we don't actually save it to a file in
this instance.




More information about the libvir-list mailing list