[PATCH] virtio-blk: drop deprecated scsi=on|off property
Michal Prívozník
mprivozn at redhat.com
Fri Apr 30 05:47:33 UTC 2021
On 4/29/21 5:52 PM, Stefan Hajnoczi wrote:
> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed
> completely at this point.
>
> Drop the scsi=on|off option. It was only available on Legacy virtio-blk
> devices. Linux v5.6 already dropped support for it.
>
> Remove the hw_compat_2_4[] property assignment since scsi=on|off no
> longer exists. Old guests with Legacy virtio-blk devices no longer see
> the SCSI host features bit.
>
> Live migrating old guests from an old QEMU with the SCSI feature bit
> enabled will fail with "Features 0x... unsupported. Allowed features:
> 0x...". We've followed the QEMU deprecation policy so users have been
> warned...
>
> I have tested that libvirt still works when the property is absent. It
> no longer adds scsi=on|off to the command-line.
>
> Cc: Markus Armbruster <armbru at redhat.com>
> Cc: Christoph Hellwig <hch at lst.de>
> Cc: Peter Krempa <pkrempa at redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert at redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com>
> ---
> docs/specs/tpm.rst | 2 +-
> docs/system/deprecated.rst | 13 ---
> docs/pci_expander_bridge.txt | 2 +-
> hw/block/virtio-blk.c | 192 +----------------------------------
> hw/core/machine.c | 2 -
> 5 files changed, 3 insertions(+), 208 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
Michal
More information about the libvir-list
mailing list