[PATCH 2/3] conf: Parse/format XML input type 'linux'

Daniel P. Berrangé berrange at redhat.com
Fri Apr 30 12:54:31 UTC 2021


On Fri, Apr 30, 2021 at 02:16:16PM +0200, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
>  docs/formatdomain.rst                    | 30 +++++++-----
>  docs/schemas/domaincommon.rng            | 20 ++++++++
>  src/conf/domain_audit.c                  |  1 +
>  src/conf/domain_conf.c                   | 61 ++++++++++++++++++++----
>  src/conf/domain_conf.h                   | 12 +++++
>  src/conf/domain_validate.c               |  8 ++++
>  src/libvirt_private.syms                 |  2 +
>  src/qemu/qemu_cgroup.c                   |  2 +
>  src/qemu/qemu_command.c                  |  1 +
>  src/qemu/qemu_domain_address.c           |  1 +
>  src/qemu/qemu_hotplug.c                  |  1 +
>  src/qemu/qemu_validate.c                 |  6 +++
>  src/security/security_apparmor.c         |  1 +
>  src/security/security_dac.c              |  2 +
>  src/security/security_selinux.c          |  2 +
>  src/security/virt-aa-helper.c            |  3 +-
>  tests/qemuxml2argvdata/input-linux.xml   | 24 ++++++++++
>  tests/qemuxml2xmloutdata/input-linux.xml |  1 +
>  18 files changed, 157 insertions(+), 21 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/input-linux.xml
>  create mode 120000 tests/qemuxml2xmloutdata/input-linux.xml
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 282176c4f4..337d07dbfb 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -5728,26 +5728,34 @@ to provide a graphics tablet for absolute cursor movement.
>       <input type='passthrough' bus='virtio'>
>         <source evdev='/dev/input/event1'/>
>       </input>
> +     <input type='linux'>
> +       <source evdev='/dev/input/event1234' grab='all' repeat='on'/>
> +     </input>

evdev is implemented on FreeBSD too, I think this should be done as

     <input type='evdev'>
       <source dev='/dev/input/event1234' grab='all' repeat='on'/>
     </input>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list