[PATCH 4/7] vmx: Drop needless check in virVMXParseDisk()

Michal Privoznik mprivozn at redhat.com
Tue Aug 3 12:32:28 UTC 2021


After previous patch it can no longer happen that @def will be
NULL and *def won't be.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/vmx/vmx.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 7a934e067d..11b6fcbdf8 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -2218,11 +2218,6 @@ virVMXParseDisk(virVMXContext *ctx, virDomainXMLOption *xmlopt, virConf *conf,
     char mode_name[32] = "";
     char *mode = NULL;
 
-    if (def == NULL || *def != NULL) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Invalid argument"));
-        return -1;
-    }
-
     if (!(*def = virDomainDiskDefNew(xmlopt)))
         return -1;
 
-- 
2.31.1




More information about the libvir-list mailing list