[PATCH 20/23] lxcNetworkParseDataIPs: Automatically free string list

Peter Krempa pkrempa at redhat.com
Wed Aug 4 11:02:40 UTC 2021


Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/lxc/lxc_native.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 9bf079bbb2..347d5f4139 100644
--- a/src/lxc/lxc_native.c
+++ b/src/lxc/lxc_native.c
@@ -548,7 +548,7 @@ lxcNetworkParseDataIPs(const char *name,
                        lxcNetworkParseData *parseData)
 {
     int family = AF_INET;
-    char **ipparts = NULL;
+    g_auto(GStrv) ipparts = NULL;
     g_autofree virNetDevIPAddr *ip = g_new0(virNetDevIPAddr, 1);

     if (STREQ(name, "ipv6") || STREQ(name, "ipv6.address"))
@@ -561,13 +561,9 @@ lxcNetworkParseDataIPs(const char *name,

         virReportError(VIR_ERR_INVALID_ARG,
                        _("Invalid CIDR address: '%s'"), value->str);
-
-        g_strfreev(ipparts);
         return -1;
     }

-    g_strfreev(ipparts);
-
     VIR_APPEND_ELEMENT(parseData->ips, parseData->nips, ip);

     return 0;
-- 
2.31.1




More information about the libvir-list mailing list