[libvirt PATCH 1/7] tests: qemuMonitorTestFree: Unlock virDomainObj before freeing

Tim Wiederhake twiederh at redhat.com
Thu Aug 5 13:08:45 UTC 2021


virDomainObj contains a mutex. Destroying a locked mutex results in
undefined behavior.

Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 tests/qemumonitortestutils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c
index 143dd954e6..f316fe823f 100644
--- a/tests/qemumonitortestutils.c
+++ b/tests/qemumonitortestutils.c
@@ -411,7 +411,7 @@ qemuMonitorTestFree(qemuMonitorTest *test)
 
     g_object_unref(test->eventThread);
 
-    virObjectUnref(test->vm);
+    virDomainObjEndAPI(&test->vm);
 
     if (test->started)
         virThreadJoin(&test->thread);
-- 
2.31.1




More information about the libvir-list mailing list