[PATCH 00/23] Remove return value from VIR_APPEND_ELEMENT and cleanups

Michal Prívozník mprivozn at redhat.com
Thu Aug 5 15:06:04 UTC 2021


On 8/4/21 1:02 PM, Peter Krempa wrote:
> Since this touches all kind of conditionally compiled code you can find
> the pipeline build results here:
> 
> https://gitlab.com/pipo.sk/libvirt/-/pipelines/347734973
> 
> Peter Krempa (23):
>   virInsertElementsN: Rename 'add' argument
>   virInsertElementsN: Split out actual insertion code
>   util: alloc: Introduce virAppendElement helper
>   util: alloc: Reimplement VIR_APPEND_ELEMENT_(COPY_)INPLACE using
>     virAppendElement
>   util: alloc: Reimplement VIR_APPEND_ELEMENT_COPY using
>     virAppendElement
>   util: alloc: Reimplement VIR_APPEND_ELEMENT_QUIET using
>     virAppendElement
>   util: alloc: Reimplement VIR_APPEND_ELEMENT using virAppendElement
>   util: alloc: Completely replace VIR_APPEND_ELEMENT_QUIET by
>     VIR_APPEND_ELEMENT
>   prlsdkAddDomainVideoInfoCt: Remove pointless cleanup section
>   xenParseXMDisk: Use automatic memory clearing and remove 'ret'
>     variable
>   qemuDomainUSBAddressAddHubs: Refactor cleanup
>   virSecuritySELinuxContextListAppend: Remove unreachable cleanup
>   qemuDomainAttachDeviceConfig: Remove pointless assignment
>   virNWFilterRuleDefToRuleInst: Remove pointless assignment
>   virObjectEventCallbackListAddID: Remove pointless cleanup of 'cb'
>   virNWFilterRuleDefToRuleInst: Restructure code to avoid cleanup
>   virNWFilterIncludeDefToRuleInst: Refactor cleanup
>   qemuProcessSetupHotpluggableVcpus: Use automatic memory freeing
>   virNetServerGetClients: Remove pointless cleanup
>   lxcNetworkParseDataIPs: Automatically free string list
>   virStorageBackendLogicalParseVolExtents: Declare one variable per line
>   virStorageBackendLogicalParseVolExtents: Move 'extents' inside the
>     loop
>   virStorageBackendLogicalParseVolExtents: Remove 'cleanup' and 'ret'
> 


>  75 files changed, 404 insertions(+), 630 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list