[libvirt PATCH 2/5] vsh: cmdEcho: use separate variable for argument

Peter Krempa pkrempa at redhat.com
Wed Aug 11 07:50:47 UTC 2021


On Tue, Aug 10, 2021 at 19:14:40 +0200, Ján Tomko wrote:
> Do not use 'arg' which is later used for an allocated string.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tools/vsh.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>

There's quite some room for rewriting the code to even avoid the use of
temps and string copies though.




More information about the libvir-list mailing list