[libvirt PATCH 00/12] tools: virsh: use g_auto more (glib chronicles)

Martin Kletzander mkletzan at redhat.com
Thu Aug 12 16:23:32 UTC 2021


On Thu, Aug 12, 2021 at 10:32:38AM +0200, Ján Tomko wrote:
>Incomprehensive series removing many cleanup sections.
>
>Patch 1/12 is common with my other series:
>[libvirt PATCH 0/3] xml: use g_auto for xmlXPathObject
>
>Ján Tomko (12):
>  util: define cleanup func for xmlXPathObject
>  tools: virsh: split variable declarations
>  tools: virsh: cmdDominfo: rename 'ostype' variable
>  tools: virsh: use automatic cleanup for virDomainObj
>  tools: virsh: use automatic cleanup for xmlXPathContext
>  tools: virsh: use automatic cleanup for xmlXPathObject
>  tools: virsh: use automatic cleanup for xmlDoc
>  tools: virsh: use automatic cleanup for vshTable
>  tools: virsh: reduce variable scope to use automatic cleanup
>  tools: virsh: use automatic cleanup for char **
>  tools: virsh: use g_autofree
>  tools: virsh: remove redundant labels
>

with the 13/12 fixup for 12/12

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

The empty lines (see PATCH 12/12) are something I feel would make it
consistent with the rest of the code, but feel free to disagree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210812/7c992951/attachment-0001.sig>


More information about the libvir-list mailing list