[PATCH] security: fix use-after-free in virSecuritySELinuxReserveLabel

Martin Kletzander mkletzan at redhat.com
Tue Aug 17 10:08:55 UTC 2021

On Tue, Aug 17, 2021 at 05:44:22PM +0800, Zhenyu Ye wrote:
>On 2021/8/17 17:21, Martin Kletzander wrote:
>> On Tue, Aug 17, 2021 at 10:55:24AM +0800, Zhenyu Ye wrote:
>>> commit 2e668a61d5ae4("Fix error handling when adding MCS labels") uses
>>> the 'pctx' in virReportError after it has been freed. Fix it.
>>> Fixes: 2e668a61d5ae4cbd6f79e096d0c394f186e132bd
>>> Signed-off-by: eillon <yezhenyu2 at huawei.com>
>> Thanks for fixing a 9 year old bug =)  One thing I am not sure about is
>> the sign off.  According to the Project Governance [0] states:
>>   "... for contributing patches, providing a 'Signed-off-by' line with
>>    the author's legal name and e-mail address to demonstrate agreement
>>    and compliance with the Developer Certificate of Origin is required."
>> Which I am not sure you maybe misconfigured somehow?  Just let me know
>> whether I should change "eillon" to "Zhenyu Ye" and I can fix that
>> before pushing the patch, or coreect me if I misunderstood.  No need to
>> send another version.
>> Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
>Thanks, help me change the "eillon" to "Zhenyu Ye".

Done and pushed, thanks for the patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210817/1ce64442/attachment-0001.sig>

More information about the libvir-list mailing list