[PATCH v2 18/23] testQemuInfoSetArgs: Remove hack for double QEMU_CAPS_LAST in caps list

Peter Krempa pkrempa at redhat.com
Tue Aug 17 16:25:19 UTC 2021


The callers don't use it any more. Remove it to avoid fragility of the
test suite.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/testutilsqemu.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index 32119e30c2..c86f7f2e39 100644
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -705,23 +705,6 @@ testQemuInfoSetArgs(struct testQemuInfo *info,

             while ((flag = va_arg(argptr, int)) < QEMU_CAPS_LAST)
                 virQEMUCapsSet(fakeCaps, flag);
-
-            /* Some tests are run with NONE capabilities, which is just
-             * another name for QEMU_CAPS_LAST. If that is the case the
-             * arguments look like this :
-             *
-             *   ARG_QEMU_CAPS, NONE, QEMU_CAPS_LAST, ARG_END
-             *
-             * Fetch one argument more and if it is QEMU_CAPS_LAST then
-             * break from the switch() to force getting next argument
-             * in the line. If it is not QEMU_CAPS_LAST then we've
-             * fetched real ARG_* and we must process it.
-             */
-            if ((flag = va_arg(argptr, int)) != QEMU_CAPS_LAST) {
-                argname = flag;
-                continue;
-            }
-
             break;

         case ARG_GIC:
-- 
2.31.1




More information about the libvir-list mailing list