[PATCH 1/3] vmx2xmltest: Drop duplicate testcases

Martin Kletzander mkletzan at redhat.com
Thu Aug 19 07:33:49 UTC 2021


On Wed, Aug 18, 2021 at 03:51:10PM +0200, Michal Privoznik wrote:
>There are three test cases are called twice. This is needless.
>Drop redundant calls.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tests/vmx2xmltest.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c
>index 453641faf1..00a87b3576 100644
>--- a/tests/vmx2xmltest.c
>+++ b/tests/vmx2xmltest.c
>@@ -245,7 +245,6 @@ mymain(void)
>     DO_TEST("cdrom-ide-device", "cdrom-ide-device");
>     DO_TEST("cdrom-ide-raw-device", "cdrom-ide-raw-device");
>     DO_TEST("cdrom-ide-raw-auto-detect", "cdrom-ide-raw-auto-detect");
>-    DO_TEST("cdrom-ide-raw-auto-detect", "cdrom-ide-raw-auto-detect");
>
>     DO_TEST("cdrom-ide-file-missing-datastore", "cdrom-ide-empty");
>     DO_TEST("cdrom-ide-file-missing-file", "cdrom-ide-empty");
>@@ -274,8 +273,6 @@ mymain(void)
>     DO_TEST("serial-device", "serial-device");
>     DO_TEST("serial-pipe-client-app", "serial-pipe");
>     DO_TEST("serial-pipe-server-vm", "serial-pipe");
>-    DO_TEST("serial-pipe-client-app", "serial-pipe");
>-    DO_TEST("serial-pipe-server-vm", "serial-pipe");

Looks like these should actually be changed to client-vm and server-app
as the test files exist for all four combinations.

>     DO_TEST("serial-network-server", "serial-network-server");
>     DO_TEST("serial-network-client", "serial-network-client");
>
>-- 
>2.31.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210819/bd27e8ae/attachment-0001.sig>


More information about the libvir-list mailing list