[libvirt PATCH 0/5] Waste less CPU on syntax-check

Ján Tomko jtomko at redhat.com
Thu Aug 19 14:12:27 UTC 2021

Use 'git ls-tree' directly instead of a wrapper script that
can possibly handle all the other versioning systems we do not use.

Instead of adding, removing, then re-adding the absolute path prefix,
only add it once per every syntax check rule.

Delete the useless-if-before-free check since we've been ignoring
its output anyway.

This speeds up 'ninja test' on my 8-core laptop from:
  19.781 s ±  0.174 s
  15.476 s ±  1.302 s

Ján Tomko (5):
  syntax-check: assume we're using git
  syntax-check: use VC_LIST_EXCEPT instead of VC_LIST
  syntax-check: replace vc-list-files
  syntax-check: drop useless useless-if-before-free
  syntax-check: remove _test_script_regex

 build-aux/syntax-check.mk        | 218 ++---------------------------
 build-aux/useless-if-before-free | 226 -------------------------------
 build-aux/vc-list-files          | 113 ----------------
 3 files changed, 9 insertions(+), 548 deletions(-)
 delete mode 100755 build-aux/useless-if-before-free
 delete mode 100755 build-aux/vc-list-files


More information about the libvir-list mailing list