[PATCH 2/2] qemu: never unlink() the core dump output file

Simon Rowe simon.rowe at nutanix.com
Fri Aug 20 08:39:56 UTC 2021


The comment above virQEMUFileOpenAs() implies any result should be
left intact.

Signed-off-by: Simon Rowe <simon.rowe at nutanix.com>
---
 src/qemu/qemu_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f31e13889e..b1ac1cb73b 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3282,8 +3282,6 @@ doCoreDump(virQEMUDriver *driver,
     if (qemuDomainFileWrapperFDClose(vm, wrapperFd) < 0)
         ret = -1;
     virFileWrapperFdFree(wrapperFd);
-    if (ret != 0)
-        unlink(path);
     return ret;
 }
 
-- 
2.22.3




More information about the libvir-list mailing list