[PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList()

Michal Privoznik mprivozn at redhat.com
Mon Aug 23 12:10:14 UTC 2021


The variable is used inside a loop in which it' allocated in each
iteration. Bring it inside the loop so that g_autoptr() kicks in
each iteration.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tools/virsh-snapshot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index ee99d0e061..e08ecb6910 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -1439,7 +1439,6 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     size_t i;
     virDomainSnapshotPtr snapshot = NULL;
     long long creation_longlong;
-    g_autoptr(GDateTime) then = NULL;
     bool tree = vshCommandOptBool(cmd, "tree");
     bool name = vshCommandOptBool(cmd, "name");
     bool from = vshCommandOptBool(cmd, "from");
@@ -1533,6 +1532,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     }
 
     for (i = 0; i < snaplist->nsnaps; i++) {
+        g_autoptr(GDateTime) then = NULL;
         g_autofree gchar *thenstr = NULL;
         g_autoptr(xmlDoc) xml = NULL;
         g_autoptr(xmlXPathContext) ctxt = NULL;
-- 
2.31.1




More information about the libvir-list mailing list