[PATCH 20/22] qemu: process: Don't set 'allowReboot' when qemu supports 'set-action'

Peter Krempa pkrempa at redhat.com
Tue Aug 24 14:44:41 UTC 2021


We don't use the value of the flag when the new handling is in place so
we don't have to initialize it.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_process.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index bbcef47885..e2bcd23954 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -6354,6 +6354,11 @@ qemuProcessPrepareAllowReboot(virDomainObj *vm)
     virDomainDef *def = vm->def;
     qemuDomainObjPrivate *priv = vm->privateData;

+    /* with 'set-action' QMP command we don't need to keep this around as
+     * we always update qemu with the proper state */
+    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SET_ACTION))
+        return;
+
     if (priv->allowReboot != VIR_TRISTATE_BOOL_ABSENT)
         return;

-- 
2.31.1




More information about the libvir-list mailing list