[PATCH 7/8] ch_domain: Allow controller and chr devices

[Daniel P. Berrangé]

On Thu, Aug 26, 2021 at 02:59:21PM -0700, William Douglas wrote:
> With the console and serial device handling fully functional, allow
> the required device types to be specified in the domain
> configuration.
> 
> Signed-off-by: William Douglas <william.douglas at intel.com>
> ---
>  src/ch/ch_domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
> index a6b87e28e5..89a8ad8f45 100644
> --- a/src/ch/ch_domain.c
> +++ b/src/ch/ch_domain.c
> @@ -215,6 +215,8 @@ chValidateDomainDeviceDef(const virDomainDeviceDef *dev,
>      case VIR_DOMAIN_DEVICE_NET:
>      case VIR_DOMAIN_DEVICE_MEMORY:
>      case VIR_DOMAIN_DEVICE_VSOCK:
> +    case VIR_DOMAIN_DEVICE_CONTROLLER:
> +    case VIR_DOMAIN_DEVICE_CHR:
>          break;
>  
>      case VIR_DOMAIN_DEVICE_LEASE:
> @@ -224,12 +226,10 @@ chValidateDomainDeviceDef(const virDomainDeviceDef *dev,
>      case VIR_DOMAIN_DEVICE_VIDEO:
>      case VIR_DOMAIN_DEVICE_HOSTDEV:
>      case VIR_DOMAIN_DEVICE_WATCHDOG:
> -    case VIR_DOMAIN_DEVICE_CONTROLLER:
>      case VIR_DOMAIN_DEVICE_GRAPHICS:
>      case VIR_DOMAIN_DEVICE_HUB:
>      case VIR_DOMAIN_DEVICE_REDIRDEV:
>      case VIR_DOMAIN_DEVICE_SMARTCARD:
> -    case VIR_DOMAIN_DEVICE_CHR:
>      case VIR_DOMAIN_DEVICE_MEMBALLOON:
>      case VIR_DOMAIN_DEVICE_NVRAM:
>      case VIR_DOMAIN_DEVICE_RNG:

This method is in fact where the validation ought to go that was mentioned
in an earlier patch.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|