[libvirt PATCH] meson: Improve network driver enablement logic

Ján Tomko jtomko at redhat.com
Fri Dec 3 15:20:02 UTC 2021


On a Friday in 2021, Andrea Bolognani wrote:
>The Homebrew package explicitly enables this driver despite us
>disabling it by default on macOS, so it must be functional to
>at least some extent and certainly can't be causing any build
>failures.
>
>Additionally, if the user has explicitly asked for the network
>driver to be enabled but libvirtd is disabled for whatever
>reason, we should error out instead of silently disabling the
>network driver.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
>Homebrew formula showing that the network driver is
>explicitly enabled in the package:
>https://github.com/Homebrew/homebrew-core/blob/3aff61292a3ed16bc715ba23fc2fa74251d82aa4/Formula/libvirt.rb#L58
>
>Test pipeline showing that enabling the network driver by
>default on macOS doesn't result in build failures:
>https://gitlab.com/abologna/libvirt/-/pipelines/421956249
>
> meson.build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211203/f77bb51a/attachment-0001.sig>


More information about the libvir-list mailing list