[libvirt PATCH v2 03/17] ch_domain: fix indentation in ch_domain

Ján Tomko jtomko at redhat.com
Fri Dec 3 17:28:54 UTC 2021


On a Thursday in 2021, Praveen K Paladugu wrote:
>Signed-off-by: Praveen K Paladugu <prapal at linux.microsoft.com>
>---
> src/ch/ch_domain.c | 130 ++++++++++++++++++++++-----------------------
> 1 file changed, 64 insertions(+), 66 deletions(-)
>
>diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
>index dd4de9e1ea..44f7d26ca4 100644
>--- a/src/ch/ch_domain.c
>+++ b/src/ch/ch_domain.c
>@@ -30,16 +30,12 @@
>
> static int
>-virCHDomainObjInitJob(virCHDomainObjPrivate *priv)
>+virCHDomainObjInitJob(virCHDomainObjPrivate * priv)

The prevailing style in libvirt codebase is no space after the '*'

> {
>     memset(&priv->job, 0, sizeof(priv->job));
>
>

[...]

>-    if (def->nserials && def->serials[0]->source->type != VIR_DOMAIN_CHR_TYPE_PTY) {
>+    if (def->nserials
>+        && def->serials[0]->source->type != VIR_DOMAIN_CHR_TYPE_PTY) {
>         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>                        _("Serial can only be enabled for a PTY"));
>         return -1;

80 columns is not a hard limit, there's no need to touch this.

Jano

>-- 
>2.27.0
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211203/91278431/attachment-0001.sig>


More information about the libvir-list mailing list