[PATCH] docs: Remove dependency on external resources

Peter Krempa pkrempa at redhat.com
Fri Dec 10 10:41:29 UTC 2021


On Thu, Dec 09, 2021 at 16:42:29 +0100, Andrea Bolognani wrote:
> The internals/eventloop document uses two images for
> illustrative purposes, but unlike other graphics included
> in the documentation these are not part of libvirt.git but
> rather were added to libvirt-media.git with
> 
>   commit fae5622074cf5e18d190496f8a43260c614599b2
>   Author: Michal Privoznik <mprivozn at redhat.com>
>   Date:   Mon Jun 6 17:27:50 2016 +0200
> 
>     Add two event loop images
> 
>     These images are going to be used in our documentation of the
>     event loop.
> 
>     Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> 
>   https://gitlab.com/libvirt/libvirt-media/-/commit/fae5622074cf5e18d190496f8a43260c614599b2
> 
> and are requested directly from there. Specifically, the
> URLs point to the libvirt.org mirror of libvirt-media.git
> instead of the primary repository hosted on GitLab.
> 
> Import the images into libvirt.git so that the website
> doesn't rely on external resources and can, if desired, be
> browsed entirely offline from installed packages.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> Redacted to strip binary and binary-adjacent blobs.
> Full patch: https://gitlab.com/abologna/libvirt/-/commit/684805e3cf65ab3bb93a92ada3b720331fae72ce
> 
>  docs/event_loop_simple.png       | Bin 0 -> 16043 bytes
>  docs/event_loop_simple.svg       | 398 +++++++++++++++++
>  docs/event_loop_worker.png       | Bin 0 -> 29696 bytes
>  docs/event_loop_worker.svg       | 708 +++++++++++++++++++++++++++++++

Shouldn't these files ...

>  docs/internals/eventloop.html.in |   4 +-

.. be inside the 'internals' directory?




More information about the libvir-list mailing list