[libvirt PATCH v2 11/12] qemu: probe for sev-guest.kernel-hashes property

[Daniel P. Berrangé]

On Fri, Dec 10, 2021 at 03:53:46PM +0100, Peter Krempa wrote:
> On Fri, Dec 10, 2021 at 11:37:34 +0000, Daniel P. Berrangé wrote:
> > This sev-guest object property indicates whether QEMU should
> > expose the kernel, ramdisk, cmdline hashes to the firmware
> > for measurement.
> > 
> > The 6.2.0 capabilities are hacked to look as if they were
> > generated with sev-guest support.
> 
> The qemu-6.2 lifecycle is not ended yet, so I'll be re-generating the
> caps, thus your hack will get lost.
> 
> Given that qemu is at rc4 now you can either wait until the final
> release is out and I update the caps or pick a different older version
> to hack.

This is a new feature in 6.2.0, so it has to be done in the
6.2.0 caps to make any sense.

As long as you can re-generate the 6.2.0 caps on a SEV capable
machine, I'll just wait for you.

> 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/qemu/qemu_capabilities.c                  |   8 ++
> >  src/qemu/qemu_capabilities.h                  |   1 +
> >  .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml  |   7 +-
> >  .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml  |   7 +-
> >  tests/domaincapsdata/qemu_6.2.0.x86_64.xml    |   7 +-
> >  .../caps_2.12.0.x86_64.replies                |  97 ++++++++++++----
> >  .../caps_3.0.0.x86_64.replies                 |  97 ++++++++++++----
> >  .../caps_3.1.0.x86_64.replies                 |  97 ++++++++++++----
> >  .../caps_4.0.0.x86_64.replies                 |  97 ++++++++++++----
> >  .../caps_4.1.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_4.2.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_5.0.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_5.1.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_5.2.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_6.0.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_6.1.0.x86_64.replies                 |  89 ++++++++++----
> >  .../caps_6.2.0.x86_64.replies                 | 109 ++++++++++++++----
> >  .../caps_6.2.0.x86_64.xml                     |   8 ++
> >  18 files changed, 895 insertions(+), 263 deletions(-)
> 
> Under the above conditions:
> 
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|