[PATCH] qemuProcessPrepareHost: Create domain private dirs as early as possible

Ján Tomko jtomko at redhat.com
Mon Dec 13 11:26:40 UTC 2021


On a Monday in 2021, Michal Privoznik wrote:
>As of ff024b60cc3 we are opening chardevs before starting QEMU.
>However, we also doing that before domain private directories are

*we are

>created. This leaves us impossible to create guest agent socket

leaves us unable
   or
makes it impossible

>which lives under priv->channelTargetDir.
>
>While creating the dirs can be moved just before
>qemuProcessPrepareHostBackendChardev() it's better to do it as
>the very first step so that this kind of error is prevented in
>future.
>
>Fixes: ff024b60cc39d5d41b1e68728a00a47e103ec4dd
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_process.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211213/5685c0e4/attachment-0001.sig>


More information about the libvir-list mailing list