[PATCH] qemuProcessPrepareHost: Create domain private dirs as early as possible

Peter Krempa pkrempa at redhat.com
Mon Dec 13 11:58:51 UTC 2021


On Mon, Dec 13, 2021 at 12:21:16 +0100, Michal Privoznik wrote:
> As of ff024b60cc3 we are opening chardevs before starting QEMU.
> However, we also doing that before domain private directories are
> created. This leaves us impossible to create guest agent socket
> which lives under priv->channelTargetDir.
> 
> While creating the dirs can be moved just before
> qemuProcessPrepareHostBackendChardev() it's better to do it as
> the very first step so that this kind of error is prevented in
> future.
> 
> Fixes: ff024b60cc39d5d41b1e68728a00a47e103ec4dd
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_process.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Oops, thanks for fixing this for me ;)




More information about the libvir-list mailing list