[PATCH 3/3] remote_driver: Implement virStreamInData() callback

[Martin Kletzander]

On Wed, Dec 08, 2021 at 09:57:41PM +0100, Martin Kletzander wrote:
>On Tue, Dec 07, 2021 at 04:34:42PM +0100, Michal Privoznik wrote:
>>When using the monolithic daemon the driver for virStream is
>>always virFDStreamDrv and thus calling virStreamInData() results
>>in calling virFDStreamInData().
>>
>>But things are different with split daemon, especially when a
>>client connects to one of hypervisor daemons (e.g. virtqemud) and
>>then lets the daemon connect to the storage daemon for
>>vol-upload/vol-download. Here, the hypervisor daemon acts like
>>both client and server. This is reflected by stream->driver
>>pointing to remoteStreamDrv, which doesn't have streamInData
>>callback implemented and thus vol-upload/vol-download with sparse
>>flag fails.

Actually vol-upload does not fail for me even without these patches.
But with your patches it works both ways, so my R-b stands.

>>
>>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2026537
>>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>
>Reviewed-by: Martin Kletzander <mkletzan at redhat.com>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211213/32985671/attachment-0001.sig>