[libvirt PATCH 19/20] tests: use g_auto in testCompareXMLToConfFiles

Ján Tomko jtomko at redhat.com
Mon Dec 13 18:43:11 UTC 2021


Use g_auto for dnsmasq context and remove the cmd variable.
It was unused since its introduction in:
commit 8b32c80df089a3612a0448c1a92abc2071d6b6a9

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 tests/networkxml2conftest.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/networkxml2conftest.c b/tests/networkxml2conftest.c
index b76d72793a..7177505918 100644
--- a/tests/networkxml2conftest.c
+++ b/tests/networkxml2conftest.c
@@ -24,9 +24,8 @@ testCompareXMLToConfFiles(const char *inxml, const char *outconf,
     int ret = -1;
     virNetworkDef *def = NULL;
     virNetworkObj *obj = NULL;
-    virCommand *cmd = NULL;
     g_autofree char *pidfile = NULL;
-    dnsmasqContext *dctx = NULL;
+    g_autoptr(dnsmasqContext) dctx = NULL;
     g_autoptr(virNetworkXMLOption) xmlopt = NULL;
 
     if (!(xmlopt = networkDnsmasqCreateXMLConf()))
@@ -82,9 +81,7 @@ testCompareXMLToConfFiles(const char *inxml, const char *outconf,
 
  fail:
     VIR_FREE(confactual);
-    virCommandFree(cmd);
     virNetworkObjEndAPI(&obj);
-    dnsmasqContextFree(dctx);
     return ret;
 }
 
-- 
2.31.1




More information about the libvir-list mailing list