[PATCH 1/2] virnettlscontext: Drop gnutls_dh_set_prime_bits()

Ani Sinha ani at anisinha.ca
Tue Dec 21 16:22:14 UTC 2021



On Tue, 21 Dec 2021, Michal Privoznik wrote:

> According to the gnutls_dh_set_prime_bits() manpage:
>
>   The function has no effect in server side.
>
> Therefore, don't call it when creating server side context.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Ani Sinha <ani at anisinha.ca>

> ---
>  src/rpc/virnettlscontext.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
> index 1a3dd92676..3b6687e7f4 100644
> --- a/src/rpc/virnettlscontext.c
> +++ b/src/rpc/virnettlscontext.c
> @@ -1233,8 +1233,6 @@ virNetTLSSession *virNetTLSSessionNew(virNetTLSContext *ctxt,
>       */
>      if (ctxt->isServer) {
>          gnutls_certificate_server_set_request(sess->session, GNUTLS_CERT_REQUEST);
> -
> -        gnutls_dh_set_prime_bits(sess->session, DH_BITS);
>      }
>
>      gnutls_transport_set_ptr(sess->session, sess);
> --
> 2.32.0
>
>




More information about the libvir-list mailing list