[PATCH v5 1/5] migration/dirtyrate: Introduce DomainGetDirtyRateInfo API

[Michal Privoznik]

On 2/1/21 1:11 PM, Daniel Henrique Barboza wrote:
> This patch is making the 'check-remote-protocol' test error out in
> my env:
> 

Indeed, any change to remote_protocol.x has to be coupled with change to 
src/remote_protocol-structs. The idea for this test is that we take 
compiled version of our RPC and use pdwtags to "decompile" it. Then, the 
output generated by pwdtags is compared against well known output stored 
in git (src/remote_protocol-structs). The idea is that we will catch 
incompatible changes made by rpcgen/compiler/developer. BTW, that is the 
reasoning behind Dan's patch:


commit e603efb6ec5d1a2295adfda934e79f022bb7bb0e
Author:     Daniel P. Berrangé <berrange at redhat.com>
AuthorDate: Mon Jan 25 18:13:57 2021 +0000
Commit:     Daniel P. Berrangé <berrange at redhat.com>
CommitDate: Tue Jan 26 12:33:31 2021 +0000

     gitlab: force dwarf4 format for debuginfo in Fedora rawhide

     Fedora 34 rawhide has pulled in a new GCC 11 build which now
     defaults to dwarf5 format. This format is not compatible with
     the pdwtags program used in our test suite to validate the
     RPC files.

     We have no need for debuginfo in CI except for pdwtags,
     so the simplest short term fix is to force the older dwarf
     version in the hope that a fixed dwarves release will
     arrive before Fedora 34 is released, or GCC 11 becomes more
     widespread. Eventually we might need to figure out a way to
     probe for compatibility but for now, we'll hope that any
     distro with GCC 11 will be able to have a fixed dwarves too.

     https://bugzilla.redhat.com/show_bug.cgi?id=1919965
     Reviewed-by: Erik Skultety <eskultet at redhat.com>
     Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>


In this case, it's developer's fault for not updating 
remote_protocol-structs to contain additions made to remote_protocol.x.

Anyway, I don't think we will need new RPC anyway. Let me comment to the 
patch itself.

Michal