[PATCH 00/14] util: Remove VIR_DISPOSE(_N)

[Peter Krempa]

Most callers are way better off using memset directly additionally few
places didn't even use it to clear sensitive data in the first place
since the name probably sounded as the right thing to use.

Peter Krempa (14):
  hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params'
  libxlMakeDomBuildInfo: Don't use VIR_DISPOSE_N for USB device list
  storage_backend_iscsi(_direct): Properly clear secrets
  libxlMakeNetworkDiskSrc: Avoid use of VIR_DISPOSE_N
  qemuDomainMasterKeyCreate: Don't use VIR_DISPOSE_N on failure
  qemu: domain: Use memset for clearing secrets instead of VIR_DISPOSE_N
  cmdSecretSetValue: Make it obvious that --file, --base64 and
    --interactive are exlcusive
  virsh: cmdSecretSetValue: Rework handling of the secret value
  virsh: cmdSecretGetValue: Use memset instead of VIR_DISPOSE_N
  virStorageBackendRBDOpenRADOSConn: Use memset instead of VIR_DISPOSE_N
  virCryptoEncryptDataAESgnutls: Use memset instead of VIR_DISPOSE_N
  storageBackendCreateQemuImgSecretPath: Use memset instead of
    VIR_DISPOSE_N
  tests: viralloc: Remove testDispose case
  util: viralloc: Remove VIR_DISPOSE(_N)

 src/hyperv/hyperv_wmi.c                    |  4 +-
 src/libvirt_private.syms                   |  1 -
 src/libxl/libxl_conf.c                     |  8 +--
 src/qemu/qemu_domain.c                     | 24 ++++++---
 src/storage/storage_backend_iscsi.c        | 16 +++---
 src/storage/storage_backend_iscsi_direct.c | 17 ++++---
 src/storage/storage_backend_rbd.c          |  5 +-
 src/storage/storage_util.c                 |  5 +-
 src/util/viralloc.c                        | 39 +-------------
 src/util/viralloc.h                        | 27 ----------
 src/util/vircrypto.c                       |  3 +-
 tests/viralloctest.c                       | 34 -------------
 tools/virsh-secret.c                       | 59 ++++++++++------------
 13 files changed, 76 insertions(+), 166 deletions(-)

-- 
2.29.2