[PATCH] virsh: Simplify @flags handing in cmdSetmem() and cmdSetmaxmem()

[Michal Privoznik]

On 2/1/21 12:29 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 1/22/21 9:28 AM, Michal Privoznik wrote:
>> What code tries to achieve is that if no flags were provided to
>> either 'setmem' or 'setmaxmem' commands then the old (no flags)
>> API is called to be able to communicate with older daemons.
>> Well, the code can be simplified a bit.
>>
>> Note that with this change the old no flag version of APIs is
>> used more often. Previously if --current argument was given it
>> resulted in *Flags() version to be called even though it is not
>> necessary - VIR_DOMAIN_AFFECT_CURRENT is implied.
>>
>> Therefore, this change in fact allows virsh to talk with broader
>> set of daemons.
> 
> I suggest adding in the end of the commit message something in the lines
> of "No user visible changes were made", making it clear that you didn't
> change the behavior of setmem and setmaxmem flags.
> 
> 
> 
> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

Pushed, thanks.

Michal