[PATCH v2 01/27] hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params'

Daniel P. Berrangé berrange at redhat.com
Wed Feb 3 10:59:04 UTC 2021


On Tue, Feb 02, 2021 at 05:55:38PM +0100, Peter Krempa wrote:
> The struct doesn't contain any secrets to clear before freeing and even
> if it did VIR_DISPOSE_N wouldn't help as the struct contains only
> pointers thus the actual memory pointing to isn't sanitized.
> 
> Just free the params array pointer and then the struct itself.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/hyperv/hyperv_wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list