[PATCH v2 05/27] virNetLibsshSessionAuthAddPrivKeyAuth: Don't unlock unlocked 'sess' on error
Daniel P. Berrangé
berrange at redhat.com
Wed Feb 3 11:03:39 UTC 2021
On Tue, Feb 02, 2021 at 05:55:42PM +0100, Peter Krempa wrote:
> The check whether @keyfile is non-NULL is before locking @sess, but uses
> the 'error' label which unlocks '@sess'.
>
> While touching the error path, update the error message to be on one
> line.
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
> src/rpc/virnetlibsshsession.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list