[PATCH v2 21/27] qemuBuildRBDSecinfoURI: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR

Daniel P. Berrangé berrange at redhat.com
Wed Feb 3 11:19:28 UTC 2021


On Tue, Feb 02, 2021 at 05:55:58PM +0100, Peter Krempa wrote:
> In this instance attempting to be correct is really pointless since the
> secret is formatted into another string which is not erased securely and
> then put on the commandline.
> 
> Keep the secure handling for correctness.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_command.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list