[libvirt PATCH v2 23/24] qemu: replace VIR_FREE with g_free in qemuFirmware*FreeContent()

Laine Stump laine at redhat.com
Thu Feb 4 03:57:50 UTC 2021


These functions are all only called as a part of qemuFirmwareFree(),
which frees the qemuFirmware object before return, so we can be sure
none of the pointers is referenced after freeing (and thus there is no
need to clear any of them).

Signed-off-by: Laine Stump <laine at redhat.com>
---
 src/qemu/qemu_firmware.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index aad39ee038..e6541d505e 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -190,8 +190,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(qemuFirmwareOSInterface, qemuFirmwareOSInterfaceFr
 static void
 qemuFirmwareFlashFileFreeContent(qemuFirmwareFlashFilePtr flash)
 {
-    VIR_FREE(flash->filename);
-    VIR_FREE(flash->format);
+    g_free(flash->filename);
+    g_free(flash->format);
 }
 
 
@@ -206,14 +206,14 @@ qemuFirmwareMappingFlashFreeContent(qemuFirmwareMappingFlashPtr flash)
 static void
 qemuFirmwareMappingKernelFreeContent(qemuFirmwareMappingKernelPtr kernel)
 {
-    VIR_FREE(kernel->filename);
+    g_free(kernel->filename);
 }
 
 
 static void
 qemuFirmwareMappingMemoryFreeContent(qemuFirmwareMappingMemoryPtr memory)
 {
-    VIR_FREE(memory->filename);
+    g_free(memory->filename);
 }
 
 
-- 
2.29.2




More information about the libvir-list mailing list